Add Llama NVFP4 PTQ recipes and MLP-only FP8-cast preset.#1645
Closed
kiranbeethoju wants to merge 1 commit into
Closed
Add Llama NVFP4 PTQ recipes and MLP-only FP8-cast preset.#1645kiranbeethoju wants to merge 1 commit into
kiranbeethoju wants to merge 1 commit into
Conversation
Expose huggingface/llama/ptq paths for partial and full NVFP4 on Llama 3.x, add the missing general nvfp4_mlp_only-kv_fp8_cast recipe, and cover loading in unit tests so recipe validation runs on CPU-only hosts. Signed-off-by: kiranbeethoju <kiranbeethoju@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR introduces new NVFP4 PTQ recipe configurations for Llama models, with both general and Hugging Face–specific variants combining MLP-only and default W4A4 quantization strategies with FP8 KV-cache casting, along with documentation and test coverage. ChangesNVFP4 PTQ Recipes and Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose huggingface/llama/ptq paths for partial and full NVFP4 on Llama 3.x, add the missing general nvfp4_mlp_only-kv_fp8_cast recipe, and cover loading in unit tests so recipe validation runs on CPU-only hosts.
What does this PR do?
Type of change: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: ✅ / ❌ / N/AAdditional Information
Summary by CodeRabbit
Release Notes
New Features
Documentation